-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow deleting last passkey in certain circumstances #41727
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
We couldn't do better at the time, but we certainly can now. I got a couple of complaints over this one, so it's definitely good to see it relaxed.
Could you add the appropriate backport labels, please?
authPref, err = authServer.UpsertAuthPreference(ctx, authPref) | ||
assert.NoError(t, err, "Resetting AuthPreference") | ||
}() | ||
func TestDeletingLastPasswordlessDevice(t *testing.T) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
func TestDeletingLastPasswordlessDevice(t *testing.T) { | |
func TestDeletingLastPasswordlessDevice(t *testing.T) { | |
t.Parallel() | |
Added v15; that's as early as we can go here, since it depends on #40911. |
Sounds good, thanks! |
Retested, will merge once tests pass |
This PR allows deleting the last passkey if the following conditions are true:
Changelog: Allowed deleting user's last passkey if they have a password and another MFA set up.
Closes #38433
Tested manually: