Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event-handler: call SearchUnstructuredEvents with smaller windows #41730

Merged
merged 3 commits into from
May 21, 2024

Conversation

tigrato
Copy link
Contributor

@tigrato tigrato commented May 17, 2024

This PR aims to reduce the windows sent from SearchUnstructuredEvents. StartTime is never updated so it's kept with its initial value which causes problems to the event handler sending windows that include more than 1Gb of data when using the Athena backend which causes failures.

Syncs with gravitational/teleport-plugins#1068

Related to #41544
Depends on #41729

@tigrato tigrato added no-changelog Indicates that a PR does not require a changelog entry backport/branch/v15 labels May 17, 2024
@tigrato tigrato requested a review from hugoShaka May 17, 2024 19:06
@hugoShaka
Copy link
Contributor

Can you add a changelog describing which kind of bug this solves?

Base automatically changed from tigrato/event-handler-skip to master May 17, 2024 20:45
This PR aims to reduce the windows sent from `SearchUnstructuredEvents`. StartTime is never updated so it's kept with its initial value which causes problems to the event handler sending windows that include more than 1Gb of data when using the Athena backend which causes failures.

Syncs with gravitational/teleport-plugins#1068
Related to #41544

Signed-off-by: Tiago Silva <tiago.silva@goteleport.com>
@tigrato tigrato force-pushed the tigrato/event-handler-windows branch from cd214d6 to c434cdc Compare May 18, 2024 17:39
@tigrato tigrato enabled auto-merge May 21, 2024 18:16
@tigrato tigrato added this pull request to the merge queue May 21, 2024
Merged via the queue into master with commit 80a249b May 21, 2024
37 checks passed
@tigrato tigrato deleted the tigrato/event-handler-windows branch May 21, 2024 18:35
@public-teleport-github-review-bot

@tigrato See the table below for backport results.

Branch Result
branch/v15 Create PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport/branch/v15 no-changelog Indicates that a PR does not require a changelog entry size/md
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants