Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

documentation: fix typo in anti-patterns.md #7237

Merged
merged 1 commit into from
May 20, 2024
Merged

documentation: fix typo in anti-patterns.md #7237

merged 1 commit into from
May 20, 2024

Conversation

roger2hk
Copy link
Contributor

@roger2hk roger2hk commented May 15, 2024 •
edited

Add the missing "`" for FailOnNonTempDialError in anti-patterns.md.

RELEASE NOTES: none

@linux-foundation-easycla Linux Foundation: EasyCLA
Copy link

linux-foundation-easycla bot commented May 15, 2024 •
edited

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: roger2hk / name: Roger Ng (1037995)

@purnesh42H purnesh42H added the Type: Documentation Documentation or examples label May 20, 2024
@purnesh42H purnesh42H self-assigned this May 20, 2024
@purnesh42H purnesh42H self-requested a review May 20, 2024 05:09
purnesh42H
purnesh42H approved these changes May 20, 2024
View reviewed changes
Copy link
Contributor

@purnesh42H purnesh42H left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add the description and milestone

@purnesh42H purnesh42H requested review from arvindbr8 and easwars and removed request for easwars and arvindbr8 May 20, 2024 05:10
@purnesh42H purnesh42H assigned dfawley and easwars and unassigned purnesh42H May 20, 2024
@easwars easwars changed the title Fix typo in anti-patterns.md documentation: fix typo in anti-patterns.md May 20, 2024
@easwars easwars added this to the 1.65 Release milestone May 20, 2024
@easwars easwars merged commit 2174ea6 into grpc:master May 20, 2024
12 checks passed
@roger2hk roger2hk deleted the fix-doc-typo branch May 20, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@easwars easwars easwars approved these changes

@purnesh42H purnesh42H purnesh42H approved these changes

Assignees

@easwars easwars

@dfawley dfawley

Labels
Type: Documentation Documentation or examples
Projects
None yet
Milestone
1.65 Release
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@roger2hk @easwars @purnesh42H @dfawley