xds: change the DumpResources API to return proto message containing the resource dump #7240
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dfawley
approved these changes
May 21, 2024
| protocmp.IgnoreFields((*v3statuspb.ClientConfig_GenericXdsConfig)(nil), "last_updated"), | ||
| protocmp.IgnoreFields((*v3adminpb.UpdateFailureState)(nil), "last_update_attempt", "details"), | ||
| // cmpopts.EquateEmpty(), | ||
| cmp.Comparer(func(a, b time.Time) bool { return true }), |
There was a problem hiding this comment.
Can't we just ignore the fields instead? Or is there no other way to ignore by type of field?
There was a problem hiding this comment.
Looks like we can get rid of all the other cmp opts, other than the ones to ignore fields.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #6898
This PR does not cover all changes required to support A71 in CSDS. It changes the
DumpResourcesAPI on theXDSclientinterface to return the actual proto message for the CSDS response. The eventual goal is as follows:DumpResourcesmethod from theXDSClientinterfaceDumpResourcesmethod on theclientImpltype which is the implementation of theXDSClientinterfacexdsclient.DumpResources()with returns the CSDS response protodumpResources()method and collate all the responses and return oneI'm currently blocked on the last two steps because our current state of things with the global singleton and global xDS clients for testing seems to be mess. I need to clean that up quite a bit before I can get to the last two steps here.
#a71-xds-fallback
RELEASE NOTES: none