Skip to content

Commit

Permalink
GitHub Actions Tidy-up (#3114)
Browse files Browse the repository at this point in the history
- Allow CodeQL workflow to be run from GitHub Actions WebUI at any time
- Set CodeQL to also check for best practises/code problems (as well as security)
- Capitalize Publish GH Action
- Change Windows Test workflow for consistent file extension (also means its formatted with Prettier) and remove leading empty linebreak
- Run Prettier (maybe we should add this to build script to ensure all code is formatted?)
- Change .gitattributes to have LF line-endings for more file types
  • Loading branch information
coliff committed Apr 23, 2024
1 parent 9006689 commit 07e9dc6
Show file tree
Hide file tree
Showing 8 changed files with 12 additions and 7 deletions.
2 changes: 2 additions & 0 deletions .gitattributes
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,8 @@
*.js text eol=lf

This comment was marked as spam.

Copy link
@Rajeshvarma2001

Rajeshvarma2001 May 27, 2024

A first-level heading

A second-level heading

A third-level heading

This comment was marked as spam.

Copy link
@Rajeshvarma2001

Rajeshvarma2001 May 27, 2024

Text that is not a quote

Text that is a quote

This comment was marked as spam.

Copy link
@Rajeshvarma2001

Rajeshvarma2001 May 27, 2024

Use git status to list all new or modified files that haven't yet been committed.

This comment was marked as spam.

Copy link
@Rajeshvarma2001

Rajeshvarma2001 May 27, 2024

Some basic Git commands are:

git status
git add
git commit

This comment was marked as spam.

Copy link
@Rajeshvarma2001

Rajeshvarma2001 May 27, 2024

The background color is #ffffff for light mode and #000000 for dark mode.

*.json text eol=lf
*.md text eol=lf
*.mjs text eol=lf
*.sh text eol=lf
*.txt text eol=lf
*.xml text eol=lf
*.yml text eol=lf
2 changes: 2 additions & 0 deletions .github/workflows/codeql-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ on:
branches:
- main
- "!dependabot/**"
workflow_dispatch:

jobs:
analyze:
Expand All @@ -27,6 +28,7 @@ jobs:
uses: github/codeql-action/init@v3
with:
languages: "javascript"
queries: +security-and-quality

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v3
2 changes: 1 addition & 1 deletion .github/workflows/publish.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: publish
name: Publish

on:
push:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@

name: Build status
name: Build status (Windows)

on:
push:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: Build status
name: Build status (Ubuntu)

on:
push:
Expand Down
3 changes: 2 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
# Changelog

## 9.0.1 (April 11, 2023)

- Fixed tests on Windows, adds Windows Testing Action [#3110](https://github.com/h5bp/html5-boilerplate/pull/3110)
- Add og:image:alt for accessibility [#3066](https://github.com/h5bp/html5-boilerplate/pull/3066)
- Upgrade to Gulp 5 [#3100](https://github.com/h5bp/html5-boilerplate/pull/3100) [#3105](https://github.com/h5bp/html5-boilerplate/pull/3105)
- ci: Use GITHUB_OUTPUT envvar instead of set-output command [#3068](https://github.com/h5bp/html5-boilerplate/pull/3068)
- Readme and Changelog updates [#3055](https://github.com/h5bp/html5-boilerplate/pull/3055) [#3057](https://github.com/h5bp/html5-boilerplate/pull/3057) [#3064](https://github.com/h5bp/html5-boilerplate/pull/3064)


## 9.0.0 (December 6, 2023)

- Removing tile images [#3023](https://github.com/h5bp/html5-boilerplate/pull/3023)
- Add Prettier [#3011](https://github.com/h5bp/html5-boilerplate/pull/3011)
- Remove Modernizr [#3002](https://github.com/h5bp/html5-boilerplate/issues/3002)
Expand Down
3 changes: 2 additions & 1 deletion docs/about-this-repo.md
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,8 @@ of our `.github` folder.
file of our `dist` folder.
- `push-to-template.yml` pushes the `HEAD` of `main` to our template repo
- `spellcheck.yml` automatically checks markdown files for typos with cSpell.
- `test.yml` runs our test suite.
- `test.yml` runs our test suite on Ubuntu.
- `test-windows.yml` runs our test suite on Windows.
- `CODE_OF_CONDUCT.md` is our Code of Conduct, based on
[Contributor Covenant.](https://www.contributor-covenant.org/)
- `CONTRIBUTING.md` contains our contribution guidelines.
Expand Down
2 changes: 1 addition & 1 deletion gulpfile.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ gulp.task('copy:misc', () =>
// (other tasks will handle the copying of these files)
`!${dirs.src}/css/main.css`,
`!${dirs.src}/index.html`,
`!**/.DS_Store`
`!**/.DS_Store`,
],
{
encoding: false,
Expand Down

0 comments on commit 07e9dc6

Please sign in to comment.