Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Tabulator to 6.2.1 #6840

Merged
merged 7 commits into from
Jun 10, 2024
Merged

Update Tabulator to 6.2.1 #6840

merged 7 commits into from
Jun 10, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 16, 2024

Supersede #6478

selectable -> selectableRows in https://tabulator.info/docs/5.6/upgrade#selection

I don't plan to expose any new functionality in this PR. This can be done in follow-up PRs.

Copy link

codecov bot commented May 16, 2024

Codecov Report

Attention: Patch coverage is 46.66667% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 81.50%. Comparing base (7377c9e) to head (4ac5f0c).
Report is 4 commits behind head on main.

Files Patch % Lines
panel/compiler.py 11.11% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6840      +/-   ##
==========================================
- Coverage   81.51%   81.50%   -0.02%     
==========================================
  Files         318      318              
  Lines       46709    46722      +13     
==========================================
+ Hits        38076    38079       +3     
- Misses       8633     8643      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro
Copy link
Member Author

hoxbro commented May 16, 2024

The failing UI tests are because of this upstream issue: olifolkerd/tabulator#4421

import panel as pn
import pandas as pd

pn.extension('tabulator')

df = pd.DataFrame({'A': [1, 2, 3], 'B': [4, 5, 6]})

pn.widgets.Tabulator(df, disabled=True).servable()

@hoxbro hoxbro marked this pull request as ready for review May 16, 2024 13:03
@hoxbro hoxbro requested a review from philippjfr May 17, 2024 15:56
@Coderambling
Copy link
Contributor

User mentions there are 58 open issues related to component tabulator of label bugs. Will this fix some of them?

https://discourse.holoviz.org/t/tabulator-issues-are-show-stoppers/7262?u=coderambling

@hoxbro
Copy link
Member Author

hoxbro commented Jun 3, 2024

Not to my knowledge. If I had fixed something, I would have updated the first post with a fixed marker.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will merge this now. Still hoping that there will be a fix upstream before we release 1.5.0.

@philippjfr philippjfr merged commit 681ddc9 into main Jun 10, 2024
15 checks passed
@philippjfr philippjfr deleted the tabulator_6.2.1 branch June 10, 2024 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants