Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing docs build #6842

Merged
merged 3 commits into from
May 20, 2024
Merged

Testing docs build #6842

merged 3 commits into from
May 20, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 16, 2024

@hoxbro hoxbro changed the title Testing Testing docs build May 16, 2024
@maximlt
Copy link
Member

maximlt commented May 16, 2024

I think the fix is to simply remove the .html suffix in both keys and values. cc @Coderambling

@Coderambling
Copy link
Contributor

D*rn I had not realized that.

Is it still OK to do i.e.:

'user_guide/APIs : 'explanation/api/index.html#apis' ? As that 2nd part (the value) does not end in .html? Or would that also cause issues?

@Coderambling
Copy link
Contributor

Coderambling commented May 16, 2024

Removed .html suffixes and did a new PR: #6844 .

If it works this time, I can re-run my tool on the dev build. If all goes well, the tool should report the above as 301, and should also show new broken links in the dev build, if there are any, so those can possibly be fixed before prod.

@hoxbro
Copy link
Member Author

hoxbro commented May 17, 2024

Have set over another run here: https://github.com/holoviz/panel/actions/runs/9130979122

doc/conf.py Outdated Show resolved Hide resolved
@philippjfr philippjfr marked this pull request as ready for review May 20, 2024 15:26
@philippjfr philippjfr merged commit d5ad9f9 into main May 20, 2024
7 checks passed
@philippjfr philippjfr deleted the revert-6833-patch-5 branch May 20, 2024 15:26
philippjfr added a commit that referenced this pull request May 21, 2024
* Revert "Update conf.py with list of Rediraffe 301 redirects. (#6833)"

This reverts commit 0b211c5.

* Apply suggestions from code review

---------

Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants