Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix blocking code in AirNow sensor #117615

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

kamiyo
Copy link
Contributor

@kamiyo kamiyo commented May 17, 2024

Proposed change

Fixed warning of blocking in AirNow sensor creation (because of a ZoneInfo call). This was actually not doing anything because AirNow returns timezones as three-letter abbreviations (i.e. CST), but ZoneInfo only works with IANA strings (i.e. "America/Chicago") because the three-letter abbreviations are non-unique. AirNow is a US based service, so the three-letter works for it, but there isn't a good way of parsing the three-letter ones, I don't think.

So, my solution is just to treat the time of observation as a string with the three-letter zone, and not bother with actually parsing the time into an actual datetime object.

I also added the state to the reporting station sensor.

In a future PR, should we think about moving more things to sensors? Dev docs say to avoid using extra_attributes for things that change (like the category and category level in this case, perhaps even observation time).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Ruff (ruff format homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @asymworks, mind taking a look at this pull request as it has been labeled with an integration (airnow) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airnow can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airnow Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

Copy link

@samip5 samip5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bdraco
Copy link
Member

bdraco commented May 19, 2024

I started adding a new async helper in #117721 that can be used for cases where we want to load uncached ZoneInfo in the event loop

@bdraco
Copy link
Member

bdraco commented May 19, 2024

Another option would be to use https://dateutil.readthedocs.io/en/stable/parser.html but it might need to parse in the executor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airnow integration does blocking I/O in the event loop to import modules
3 participants