Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Spacing Issue in Delete Confirmation Message #1063

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Loujayna1
Copy link
Contributor

@Loujayna1 Loujayna1 commented Apr 13, 2024

Description

This pull request addresses an issue where the delete confirmation message displays the item name concatenated directly with the word "delete" without a space in between. This results in a visually incorrect confirmation message.

Steps to Test

Tested the fix by triggering delete actions for various items.
Verified that the delete confirmation message now correctly displays the item name with a space between "delete" and the item name.
Ensured that the spacing issue is resolved and the delete confirmation message is visually correct.

Screenshots (if applicable)

### Before:

Screenshot 2024-04-14 011011
Screenshot 2024-04-14 010933
Screenshot 2024-04-14 005415
Screenshot 2024-04-14 005221
Screenshot 2024-04-14 004854
Screenshot 2024-04-14 004748
Screenshot 2024-04-14 003952
Screenshot 2024-04-14 000430
Screenshot 2024-04-14 005105

### After:

Screenshot 2024-04-14 014657
Screenshot 2024-04-14 014626
Screenshot 2024-04-14 014600
Screenshot 2024-04-14 014538
Screenshot 2024-04-14 014513
Screenshot 2024-04-14 014434
Screenshot 2024-04-14 014414
Screenshot 2024-04-14 014056
Screenshot 2024-04-14 015019

Checklist

  • I have tested these changes
  • I have updated the relevant documentation
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the codebase
  • My changes generate no new warnings or errors
  • The title of my pull request is clear and descriptive

backend/.env Outdated
@@ -1,4 +1,4 @@
#DATABASE = "mongodb://localhost:27017"
DATABASE = "mongodb+srv://yassine3:jajaja123@cluster0.78sjwy4.mongodb.net/?retryWrites=true&w=majority"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't push .env changes to the code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! thank you

@salahlalami salahlalami changed the base branch from dev to master April 24, 2024 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants