Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(web): add archive shortcut to grid #9499

Merged
merged 7 commits into from
Jun 6, 2024

Conversation

Snowknight26
Copy link
Contributor

@Snowknight26 Snowknight26 commented May 15, 2024

Closes #9466.

Per the keyboard shortcut modal, Shift+A now works on the grid.

@Snowknight26
Copy link
Contributor Author

Not sure if the keyboard shortcut modal is actually supposed to appear globally since some of the actions don't apply in all contexts (i for show/hide info is only applicable when viewing assets), but c'est la vie.

Copy link
Member

@danieldietzler danieldietzler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me!

Copy link
Contributor

@jrasm91 jrasm91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work well.

@Snowknight26
Copy link
Contributor Author

Need to merge main in again but I'm wondering.. is this superseded by #9712?

@jrasm91
Copy link
Contributor

jrasm91 commented Jun 6, 2024

Probably, but this one works and doesn't have any conflicts. That one has a bunch and other unresolved comments, so I'm just going to merge it.

@jrasm91 jrasm91 merged commit 7a46f80 into immich-app:main Jun 6, 2024
22 checks passed
@Snowknight26 Snowknight26 deleted the add-archive-shortcut branch June 6, 2024 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

timeline view - shortcut Shift-a not working to move assets to archive
5 participants