Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves checkbox for hiding self view to video tab from the general tab #14553

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

smarizvi110
Copy link

resolves #14407

Moves checkbox for hiding self view to video tab from the general tab, under mirror my video checkbox

@jitsi-jenkins
Copy link

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

@smarizvi110
Copy link
Author

Ran into a few issues with linting and forgot to pass the disableSelfView bool to the video popup. Should be fine now.

@smarizvi110
Copy link
Author

Missed one lint due to expecting the linter to ignore the line. Fixed.

@saghul
Copy link
Member

saghul commented Mar 27, 2024

IIRC it used to be there but we had to move it for some reason.

We need to check with design.

@smarizvi110
Copy link
Author

Made the pull request branch up-to-date with the main branch.

@saghul saghul changed the title resolves #14407 Moves checkbox for hiding self view to video tab from the general tab Apr 9, 2024
@saghul saghul added the ui/ux User Interface / User Experience related issues label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui/ux User Interface / User Experience related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move Hide Self View to the Video Tab
3 participants