Toolbox-custom-order #14759
Merged
Toolbox-custom-order #14759
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hristoterezov
force-pushed
the
toolbox-custom-order
branch
2 times, most recently
from
2f10d97
to
357ee29
Compare
damencho
reviewed
May 17, 2024
hristoterezov
force-pushed
the
toolbox-custom-order
branch
from
357ee29
to
003e3f5
Compare
saghul
reviewed
May 23, 2024
| @@ -440,6 +440,7 @@ export interface IConfig { | |||
| }; | |||
| localSubject?: string; | |||
| locationURL?: URL; | |||
| mainToolbarButtons?: Array<Array<ToolbarButton | string>>; | |||
There was a problem hiding this comment.
Won't it always be an array of strings?
There was a problem hiding this comment.
Generally yes, since ToolbarButton is ultimately a string. But when we add the ToolbarButton type this can improve the autocomplete in the IDE, you get some suggestions from ToolbarButton type. In addition it looks a little but clearer to me because it shows that you can put our stock buttons or a custom one (which is represented by | string).
If you don't like it I don't mind removing the ToolbarButton part tho.
There was a problem hiding this comment.
Please do, since it doesn't match the actual config.
| if (isHangupVisible) { | ||
| sliceIndex -= 1; | ||
| } | ||
| // if we have 1 button in the overflow menu it is better to directly display it in the main toolbar by replacing |
hristoterezov
force-pushed
the
toolbox-custom-order
branch
from
003e3f5
to
718579d
Compare
saghul
previously approved these changes
May 23, 2024
As part of the PR, it also fixes: - Removes button aliases - Unifies the keys in the object returned by getAllToolboxButtons and the button keys - Makes sure that the number of buttons displayed are always the same as the number of buttons specified in the thresholds and removes the exception for not filling up the main toolbar with buttons from overflow menu when reactions button is disabled. - Introduces a priority for buttons that will be used to fill empty spaces in the main toolbar.
hristoterezov
force-pushed
the
toolbox-custom-order
branch
from
718579d
to
fa708c2
Compare
damencho
approved these changes
May 23, 2024
saghul
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the PR, it also fixes: