[cypress] nested set table #__menu #43456
Open
+38
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should really not use the "After" and "afterEach" event: https://docs.cypress.io/guides/references/best-practices#Using-after-Or-afterEach-Hooks |
laoneo
reviewed
May 30, 2024
|
still weird the drone failure I would say "it works on my end" 🤕 |
|
What can be that the chaining I pointed out here can cause the issues as the task function does run async. Try my suggestion, perhaps it brings an improvement. |
|
drone is happy now 👌 |
laoneo
reviewed
Jun 8, 2024
laoneo
reviewed
Jun 8, 2024
laoneo
reviewed
Jun 9, 2024
tests/System/support/commands/db.js
Outdated
| const menuItem = { ...defaultMenuItemOptions, ...menuItemData }; | ||
| // Extract the component from the link | ||
| const component = (new URLSearchParams(menuItem.link.replace('index.php', ''))).get('option'); | ||
| cy.task('queryDB', `SELECT extension_id FROM #__extensions WHERE name = '${component}'`).then((id) => { |
tests/System/support/commands/db.js
Outdated
| cy.task('queryDB', `SELECT extension_id FROM #__extensions WHERE name = '${component}'`).then((id) => { | ||
| // Get the correct component id from the extensions record | ||
| menuItem.component_id = id[0].extension_id; | ||
| cy.task('queryDB', `UPDATE #__menu SET rgt = rgt + 2 WHERE rgt >= '${defaultMenuItemOptions.lft}'`) |
There was a problem hiding this comment.
and here a return. Otherwise the calling function doesn't get the id of the menu item.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request for Issue #43441 .
Summary of Changes
delete an item on nested set table
Testing Instructions
run
npm run cypress:run -- --spec 'tests/System/integration/api/com_menus/SiteMenuItems.cy.js'Actual result BEFORE applying this Pull Request
fail
Expected result AFTER applying this Pull Request
success
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed