Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cypress): add pix payment method to adyen #4685

Closed
wants to merge 1 commit into from

Conversation

pixincreate
Copy link
Member

@pixincreate pixincreate commented May 17, 2024

Type of Change

  • Bugfix
  • New feature
  • Enhancement
  • Refactoring
  • Dependency updates
  • Documentation
  • CI/CD

Description

  • Added Pix payment method type to Cypress
  • Auto formatted by prettier
  • Prettier library yet to be added in this PR
  • Auto-formatting the entire cypress will be taken in a different PR once stabilised
connector: "adyen
payment_method: "bank_transfer"
payment_method_type: "pix"

Flow:

  • Create a payment intent
  • Confirm
  • Validate QR

Note

SDK says payment is processing, but on dashboard, even after force_psync, the status remains as requires_customer_action.
One would also need to login to Adyen dashboard and manually move the status from offer to sale to move the payment status to processing
Adyen login is behind a 2FA

Additional Changes

  • This PR modifies the API contract
  • This PR modifies the database schema
  • This PR modifies application configuration/environment variables

Motivation and Context

NIL

How did you test it?

image

Checklist

  • I formatted the code cargo +nightly fmt --all
  • I addressed lints thrown by cargo clippy
  • I reviewed the submitted code
  • I added unit tests for my changes where possible

@pixincreate pixincreate added A-CI-CD Area: Continuous Integration/Deployment S-waiting-on-review Status: This PR has been implemented and needs to be reviewed C-test Category: Tests labels May 17, 2024
@pixincreate pixincreate added this to the May 2024 Release milestone May 17, 2024
@pixincreate pixincreate self-assigned this May 17, 2024
@pixincreate pixincreate requested review from a team as code owners May 17, 2024 12:27
"license": "ISC"
"license": "ISC",
"dependencies": {
"jsqr": "^1.4.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This dependency has been added intentionally and is used in line 770 of commands.js (fetchAndParseQRCode) which is called in line 881 of commands.js just so that we can parse the QR the code and read the value.

Copy link
Contributor

@SamraatBansal SamraatBansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure this is inline with changes being done in the framework at #4624

@pixincreate pixincreate changed the base branch from main to cypress_framework_enhancement May 20, 2024 09:41
},
"payment_method": "card",
"payment_method_type": "credit",
"payment_method_data": {},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has been made empty to allow bank_transfers to work. Have verified with cards, it does not harm them.

Base automatically changed from cypress_framework_enhancement to main May 21, 2024 10:35
@pixincreate
Copy link
Member Author

Closing in favour of #4766

@pixincreate pixincreate deleted the cypress-adyen-pix-pm branch May 25, 2024 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-CI-CD Area: Continuous Integration/Deployment C-test Category: Tests S-waiting-on-review Status: This PR has been implemented and needs to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants