config: add customizable metric name prefix #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the metric name was always the query name, prefixed with `sql_`. Now, that remains the behavior if a prefix is not provided in the job config. An empty string may explicitly be provided, in which case `sql_` is not prepended to the query name.
anitgandhi
commented
Nov 29, 2023
| @@ -118,6 +118,9 @@ For a more realistic example please have a look at [examples/kubernetes/configma | |||
| jobs: | |||
| # each job needs a unique name, it's used for logging and as an default label | |||
| - name: "example" | |||
There was a problem hiding this comment.
possible point of discussion: i considered using the job name as the prefix, but 2 things stopped me from that:
- it would change the existing behavior (
sql_prefix) in a non-backwards-compatible way. however, since this hasn't hit a 1.0 release, i wasn't sure if that would be ok - the job name is already used as a default label
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the metric name was always the query name, prefixed with
sql_. Now, that remains the behavior if a prefix is not provided in the job config. An empty string may explicitly be provided, in which casesql_is not prepended to the query name.