Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue installing artifacts from PR builds with multiple runs #10122

Merged
merged 1 commit into from
May 23, 2024

Conversation

brandond
Copy link
Contributor

Proposed Changes

Fix issue installing artifacts from builds with multiple runs

Also makes error handling and variable capitalization consistent with other functions.

Types of Changes

bugfix

Verification

See linked issue

Testing

Linked Issues

User-Facing Change


Further Comments

@brandond brandond requested a review from a team as a code owner May 17, 2024 17:55
@brandond brandond requested a review from dereknola May 17, 2024 17:57
@brandond brandond changed the title Fix issue installing artifacts from builds with multiple runs Fix issue installing artifacts from PR builds with multiple runs May 17, 2024
Copy link

codecov bot commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 41.81%. Comparing base (1d22b69) to head (34f7636).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #10122      +/-   ##
==========================================
- Coverage   47.58%   41.81%   -5.77%     
==========================================
  Files         173      173              
  Lines       14651    14651              
==========================================
- Hits         6972     6127     -845     
- Misses       6348     7361    +1013     
+ Partials     1331     1163     -168     
Flag Coverage Δ
e2etests 36.44% <ø> (-9.83%) ⬇️
inttests 37.10% <ø> (+17.31%) ⬆️
unittests 11.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Also makes error handling and variable capitalization consistent with other functions.

Signed-off-by: Brad Davidson <brad.davidson@rancher.com>
Copy link
Contributor

@manuelbuil manuelbuil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIUC, uppercase variables are typically used for env variables. So I think this change is good and makes it closer to bash best practices. Using curly braces, ${var} would even be better I think

@brandond
Copy link
Contributor Author

no backports, since install script changes only go to master

@brandond brandond merged commit e8950a0 into k3s-io:master May 23, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants