Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for iOS, macOS and Android (and possibly other platforms) in _WindowSDL2Storage.get_window_info #8651

Open
misl6 opened this issue Mar 19, 2024 · 2 comments
Labels
easy Should be easy to fix
Milestone

Comments

@misl6
Copy link
Member

misl6 commented Mar 19, 2024

Currently only Linux (X11, Wayland) and Windows are returning a valid "info" object in _WindowSDL2Storage.get_window_info.

As this feature will now be needed by #8650 to expose a valid native window handle (e.g. for accessibility tools ), is important to have an implementation for every platform that Kivy officially supports.

Adding support, for the SDL2 (or soon SDL3) Window provider, seems quite straightforward, as SDL_GetWindowWMInfo already provides the data we need inside the returned SDL_SysWMinfo struct.

@misl6 misl6 added this to the 3.0.0 milestone Mar 19, 2024
@misl6 misl6 added the easy Should be easy to fix label Mar 19, 2024
@misl6
Copy link
Member Author

misl6 commented Mar 28, 2024

Hi @its-joseph-230606 , why you think we should close this issue? Do you have a PR for it?

@misl6
Copy link
Member Author

misl6 commented Mar 31, 2024

As we're performing a migration from SDL2 to SDL3, please keep this just as a backlog, and do not start working on it as the implementation of such a feature on SDL3 is completely different (and easier).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Should be easy to fix
Projects
Status: Ready
Development

No branches or pull requests

1 participant