Expose a native_handle property on WindowBase
#8650
Conversation
|
Thanks for opening your first pull request here! 💖 Please check out our contributing guidelines. |
DataTriny
force-pushed
the
native-window-handle
branch
from
2b66148
to
0363397
Compare
DataTriny
force-pushed
the
native-window-handle
branch
from
0363397
to
a24a2b7
Compare
There was a problem hiding this comment.
Hi @DataTriny !
Thank you for taking care of it.
I've left a comment regarding a Cython deprecation, please consider taking care of it so we do not introduce deprecated code.
Regarding missing platforms: I will open a separate issue opened issue (#8651) to target it on a separate PR, but will be quite straightforward as SDL_GetWindowWMInfo already provides the info we need.
What do you think about adding a test that exercises this new feature?
kivy/core/window/_window_sdl2.pyx
Outdated
| def get_native_handle(self): | ||
| window_info = self.get_window_info() | ||
|
|
||
| IF USE_WAYLAND: |
There was a problem hiding this comment.
We're trying to avoid IF/ELSE and DEF on new code (and slowly migrating during changes required for 3.0.0) as is deprecated.
See: http://docs.cython.org/en/latest/src/userguide/migrating_to_cy30.html#deprecation-of-def-if
There was a problem hiding this comment.
I always try to make my changes blend into what's already there. I now have to import the struct for each platform/graphic system since the imports at the top of the file still use conditional compilation. Is it OK?
| if setupconfig.USE_WAYLAND: | ||
| self.assertNotEqual(native_handle, 0) | ||
|
|
||
| if setupconfig.PLATFORM == 'win32': |
There was a problem hiding this comment.
This check is different from the one in the method being tested, but this is what is used in test_window_info.py so I figured maybe your CI expects this exact configuration.
| @@ -126,3 +127,19 @@ def test_window_opacity_clamping_negative(self): | |||
| if self.check_opacity_support(): | |||
| self.Window.opacity = -1.5 | |||
| self.assertEqual(self.Window.opacity, 0.0) | |||
|
|
|||
|
|
|||
| class WindowNativeHandleTest(GraphicUnitTest): | |||
There was a problem hiding this comment.
I guess another property of native handles is that they should not change over time, but I really don't know how to exercise that in a test.
There was a problem hiding this comment.
Checking if we're getting a value when we expect one is fine for me ATM.
|
Congrats on merging your first pull request! 🎉🎉🎉 |
Maintainer merge checklist
Component: xxxlabel.api-deprecationorapi-breaklabel.release-highlightlabel to be highlighted in release notes.versionadded,versionchangedas needed.Closes #8597
Retrieving a pointer to the
NSWindowwill also be required for AccessKit integration, but the native code is not present at the moment.