Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filechooser widgets handle system files without logging errors #8509

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Filechooser widgets handle system files without logging errors #8509

wants to merge 1 commit into from

Conversation

Julian-O
Copy link
Contributor

  • Added failing test before implementing fix.
  • Added super-basic iconview test, because the code is never exercised.
  • Refactor is_hidden so it doesn't fail: Use built-in os.stat instead of win32file's GetFileAttributesExW() because it handles (in use) system files.
    ^ Fixes Python 3.7 Filechooser crash #5873
  • Sort imports according to PEP8.
  • Stop (conditionally) importing win32file.
  • Add support for macOS's UF_Hidden attributes.
  • Confirm new tests are now passing.

Maintainer merge checklist

  • Title is descriptive/clear for inclusion in release notes.
  • Applied a Component: xxx label.
  • Applied the api-deprecation or api-break label.
  • Applied the release-highlight label to be highlighted in release notes.
  • Added to the milestone version it was merged into.
  • Unittests are included in PR.
  • Properly documented, including versionadded, versionchanged as needed.

@Julian-O
Refactor is_hidden to address kivy#5873
ff6584c 
* Added failing test before implementing fix.
* Added super-basic iconview test, because the code is never exercised.
* Refactor is_hidden so it doesn't fail: Use built-in `os.stat` instead of win32file's `GetFileAttributesExW()` because it handles (in use) system files.
* Sort imports according to PEP8.
* Stop (conditionally) importing win32file.
* Add support for macOS's UF_Hidden attributes.
* Confirm new tests are now passing.
@Julian-O Julian-O requested a review from misl6 January 15, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@misl6 misl6 Awaiting requested review from misl6

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python 3.7 Filechooser crash
1 participant
@Julian-O