Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update central dashboard to NodeJS 16 #7578

Merged

Conversation

thesuperzapper
Copy link
Member

This PR updates the central-dashboard to use NodeJS 16.

WARNING: node 16 is the latest we can use without significant refactoring.

This PR also updates the following dependency packages (to allow for NodeJS 16 support):

  • @kubernetes/client-node to 0.19.0
  • express to 4.19.2
  • @grpc/grpc-js to 1.10.8
  • @types/serve-static to 1.15.5
  • typescript to 4.9.5
  • webpack to 4.47.0

There were also a number of typescript linting errors which the newer versions of everything seem to detect, so I fixed those also.

Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
Signed-off-by: Mathew Wicks <5735406+thesuperzapper@users.noreply.github.com>
@ederign
Copy link
Member

ederign commented May 20, 2024

/approve
/lgtm

@ederign
Copy link
Member

ederign commented May 20, 2024

/lgtm

@ederign
Copy link
Member

ederign commented May 20, 2024

/lgmt

@thesuperzapper
Copy link
Member Author

/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: thesuperzapper

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit 1b5d92d into kubeflow:master May 20, 2024
5 checks passed
@thesuperzapper thesuperzapper deleted the update-central-dashboard branch May 21, 2024 05:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants