Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhancement(scheduler): share waitingPods among profiles #124926

Merged
merged 1 commit into from
May 21, 2024
Merged

enhancement(scheduler): share waitingPods among profiles #124926

merged 1 commit into from
May 21, 2024
+229 −8

Conversation

kerthcet
Copy link
Member

What type of PR is this?

What this PR does / why we need it:

Share waitingPods among scheduler profiles to help us traverse all pods waiting in the permit stage within the current scheduler app, rather than the pods that using the current profile for scheduling and waiting in the permit stage.

Other context:

We revert this PR for goroutine leakage https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-unit/1770147457137643520, however, this may because klog reports the log too quick before waiting for the gorouine to complete, also see discussion here #123707. Sorry for the revert @NoicFank hope it's not too late.

Push this feature again and make you the main author. also cc @Huang-Wei

Which issue(s) this PR fixes:

Fixes #122945

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Users can traverse all the pods that are in the scheduler and waiting in the permit stage through method `IterateOverWaitingPods`. In other words,  all waitingPods in scheduler can be obtained from any profiles. Before this commit, each profile could only obtain waitingPods within that profile.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label May 17, 2024
@kerthcet
Copy link
Member Author

/sig scheduling
/kind feature

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. kind/feature Categorizes issue or PR as related to a new feature. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels May 17, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kerthcet

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@kerthcet
Copy link
Member Author

/retest

@kerthcet
Copy link
Member Author

kindly ping @Huang-Wei

@NoicFank
Copy link
Contributor

@kerthcet Thanks for constantly pushing this feature forward. LGTM

@Huang-Wei
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 21, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: de035d6c0b44361ea193879c3f73481f485226c3

@Huang-Wei
Copy link
Member

Let's track the real cause and fix in #123707.

@NoicFank
Copy link
Contributor

/retest

1 similar comment
@kerthcet
Copy link
Member Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit 027f346 into kubernetes:master May 21, 2024
14 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.31 milestone May 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damemi damemi Awaiting requested review from damemi

@sanposhiho sanposhiho Awaiting requested review from sanposhiho

Assignees

@Huang-Wei Huang-Wei

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.31
Development

Successfully merging this pull request may close these issues.

Scheduler: Share frameworkImpl.waitingPods among profiles
4 participants
@kerthcet @k8s-ci-robot @NoicFank @Huang-Wei