feat: add schema to TableNodes within RawNodes @ WithSchemaPlugin.
#826
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
igalklebanov
added
enhancement
igalklebanov
changed the title
TableNodes within RawNodes @ WIthSchemaPlugin.TableNodes within RawNodes @ WithSchemaPlugin.
| @@ -517,6 +520,72 @@ for (const dialect of DIALECTS.filter( | |||
| }) | |||
| }) | |||
|
|
|||
| describe('raw sql', () => { | |||
There was a problem hiding this comment.
I think a little copy-pasta is better than these DRY tests that are really really hard to read. This is fine, but in the future, if there's only a couple of cases, just copy paste them.
There was a problem hiding this comment.
Absolutely agree, it's a mess.
|
|
||
| subsuites.forEach(([name, builder]) => { | ||
| describe(`${name}.table`, () => { | ||
| it('should add schema', () => { |
There was a problem hiding this comment.
Add a test case like this:
sql`
select * from person as p
inner join pets on pets.owner_id = ${sql.ref('p.id')}
`I think the current code would incorrectly add schema to mammals.p.id 🤔
It might be impossible to handle this correctly since we don't know how ref and table are used in raw SQL.
There was a problem hiding this comment.
Damn, got some rethinking to do. Great catch! 💪
Maybe if we limit the scope to just eb.ref & eb.table - since it forces usage of things from query context - and find a way to skip aliases (don't remember if I handled it) - this could work.
closes #761.
When using
sql.table,eb.table,sql.refandeb.ref, we createTableNodes.When executing
sqltemplate tag queries or parts of queries, any plugins on the db instance are run - includingWithSchemaPluginwhen available.Currently, the plugin doesn't handle
RawNodes, so we only get partial schema addition.This PR addresses that. Now using
.refand.tableis even more powerful. 👓