Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: revision styles for workflow #4087

Merged
merged 5 commits into from
May 30, 2024
Merged

Conversation

lawvs
Copy link
Contributor

@lawvs lawvs commented May 4, 2024

Description

This pull request involves fixing some minor style issues.

  • Fix incorrect model position
Screen.Recording.2024-05-05.at.03.03.23.mov
  • Fix incorrect cursor style in the Panel component
Screen.Recording.2024-05-05.at.03.04.57.mov
  • Support toggle the Feature panel
Screenshot 2024-05-05 at 03 06 01

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

How Has This Been Tested?

  • See video above

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods
  • optional I have made corresponding changes to the documentation
  • optional I have added tests that prove my fix is effective or that my feature works
  • optional New and existing unit tests pass locally with my changes

@lawvs lawvs marked this pull request as ready for review May 4, 2024 19:10
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. 🌊 feat:workflow Workflow related stuff. 🐞 bug Something isn't working labels May 4, 2024
@takatost takatost requested review from iamjoel and zxhlyh May 7, 2024 06:52
@lawvs lawvs force-pushed the fix/styles branch 2 times, most recently from 713fbfc to bf5b75f Compare May 15, 2024 04:24
@crazywoola crazywoola self-requested a review May 25, 2024 04:51
@crazywoola
Copy link
Member

@lawvs Hello please fix the conflict, I will review it asap.

lawvs added 5 commits May 30, 2024 18:40
Property 'query_prompt_template' is missing in type '{ window: { enabled: false; size: number; }; }' but required in type 'Memory'.ts(2741)
Code Actions' behavior on save in the editor has been modified from Booleans to an enum
@lawvs
Copy link
Contributor Author

lawvs commented May 30, 2024

@crazywoola Done

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2024
@crazywoola crazywoola merged commit 4308a79 into langgenius:main May 30, 2024
7 checks passed
@lawvs lawvs deleted the fix/styles branch May 30, 2024 11:24
Sakura4036 pushed a commit to Sakura4036/dify that referenced this pull request Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐞 bug Something isn't working 🌊 feat:workflow Workflow related stuff. lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants