Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports quick jump #4225

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

TinsFox
Copy link
Contributor

@TinsFox TinsFox commented May 9, 2024

Description

Added jump to specified page number for table

Export-1715260541550.mp4

Type of Change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Added jump to specified page number for table

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code. labels May 9, 2024
@TinsFox TinsFox marked this pull request as draft May 9, 2024 13:27
@TinsFox
Copy link
Contributor Author

TinsFox commented May 9, 2024

Need to handle the situation of jumping to non-existent pages

@SuperevanZ
Copy link

Thanks for submitting the PR! This feature is really useful, but it looks a bit off visually. The pagination component itself has a lot of room for improvement, and we'll be designing it more comprehensively.

@TinsFox
Copy link
Contributor Author

TinsFox commented May 9, 2024

Thanks for submitting the PR! This feature is really useful, but it looks a bit off visually. The pagination component itself has a lot of room for improvement, and we'll be designing it more comprehensively.

Do you mean the functional convenience or the visual aspect? Where can I find the design draft of dify 🤔

@TinsFox TinsFox marked this pull request as ready for review May 10, 2024 02:01
@dosubot dosubot bot added the 💪 enhancement New feature or request label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💪 enhancement New feature or request size:M This PR changes 30-99 lines, ignoring generated files. ☕️ typescript Pull request that update TypeScript code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants