Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: merge lint-staged script #4404

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

chore: merge lint-staged script #4404

wants to merge 20 commits into from

Conversation

TinsFox
Copy link
Contributor

@TinsFox TinsFox commented May 15, 2024

Description

Merge lint-staged script

Fixes # (issue)

Type of Change

Please delete options that are not relevant.

  • Improvement, including but not limited to code refactoring, performance optimization, and UI/UX improvement

Suggested Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings
  • I ran dev/reformat(backend) and cd web && npx lint-staged(frontend) to appease the lint gods

@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. javascript Pull requests that update Javascript code labels May 15, 2024
@takatost takatost requested a review from nite-knite May 16, 2024 03:45
@bowenliang123
Copy link
Contributor

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

kerlion and others added 19 commits May 20, 2024 09:47
@kerlion @TinsFox
fix the issue of MILVUS_DATABASE has no effect. (langgenius#4353)
b90e2ae
@chazzhou @TinsFox
fix: add timeout to SMTPClient to prevent worker blocking (langgenius…
0e31f40 
…#4352)
@shutootaki @TinsFox
docs: Add CONTRIBUTING_JA.md (langgenius#4383)
d4ca02e
@kotamat @crazywoola @TinsFox
Fix: setup google-storage client (langgenius#4296)
f055cad 
Co-authored-by: kotamat <kota1681@gmail.com>
Co-authored-by: crazywoola <427733928@qq.com>
@Yash-1511 @TinsFox
FIX: fix the temperature value of ollama model (langgenius#4027)
1a4317f
@hjlarry @TinsFox
Fix HTTP REQUEST NODE is always waiting but endpoint have responsed (l…
63a726c 
…anggenius#4395)
@Yeuoly @TinsFox
chore: remove model as tool (langgenius#4409)
bda9aa9
@zxhlyh @TinsFox
fix: workflow delete edge when node is selected (langgenius#4414)
1b09f7b
@charli117 @crazywoola @TinsFox
Optimize webscraper (langgenius#4392)
1e6cb53 
Co-authored-by: luowei <glpat-EjySCyNjWiLqAED-YmwM>
Co-authored-by: crazywoola <427733928@qq.com>
Co-authored-by: crazywoola <100913391+crazywoola@users.noreply.github.com>
@VoidIsVoid @TinsFox
chore: remove useless code in knowledge_retrieval_node (langgenius#4412)
b6d4282
@xtuhcy @TinsFox
Custom sqlalchemy database uri scheme is supported (langgenius#4367)
5ae9159
@GarfieldDai @TinsFox
Remove useless code (langgenius#4416)
e19b466
@sinomoe @TinsFox
feat: support doubao llm and embeding models (langgenius#4431)
11bf551
@hanfangyuan4396 @TinsFox
fix: wrong category name in examples of question classifier completio…
c0ea615 
…n prompt (langgenius#4421)
@HiChen404 @TinsFox
fix: self node type shouldn't show in the picker (langgenius#4445)
6f2b118
@takatost @TinsFox
feat: add pre ping for sqlalchemy configuration (langgenius#4454)
af0eb22
@JohnJyong @TinsFox
fix the wrong env variable AZURE_BLOB_CONTAINER_NAME (langgenius#4455)
844402c
@jiaqianjing @TinsFox
add llm: ernie-character-8k of wenxin (langgenius#4448)
25b6c97
@TinsFox
chore: remove unnecessary prettier scripts
9dca581
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:S This PR changes 10-29 lines, ignoring generated files. labels May 20, 2024
@TinsFox
Copy link
Contributor Author

TinsFox commented May 20, 2024

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

Sorry, I forgot to remove the prettier script before submitting.

@bowenliang123
Copy link
Contributor

The title and the description emphasize the key change is merging eslints options, while prettier linter action is introduced for the js scripts as well. Is it the main purpose and what's impact of the PR ? If prettier is introduced for lining, how does it aligned to the automated style checks?

Sorry, I forgot to remove the prettier script before submitting.

Thanks for the reply. Let's know when the changes are ready.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nite-knite nite-knite Awaiting requested review from nite-knite

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
javascript Pull requests that update Javascript code size:XL This PR changes 500-999 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet