Add German translation #2243
Add German translation #2243
Conversation
like "Payee" and "UUID" to maintain compatibilty with existing journals when using a different locale as prior to this change Ledger would only recognize the translation of "Payee" or "UUID".
| @@ -126,6 +126,8 @@ string post_t::payee_from_tag() const | |||
| { | |||
| if (optional<value_t> post_payee = get_tag(_("Payee"))) | |||
| return post_payee->as_string(); | |||
| else if (optional<value_t> post_payee = get_tag("Payee")) | |||
| return post_payee->as_string(); | |||
There was a problem hiding this comment.
Assume someone has a Ledger journal and has made use of the special metadata tag Payee. With the changes in this PR they are able to make Ledger speak German.
Without this change their journal would no longer recognize the English Payee keyword they have in their journal as Ledger would look for the German equivalent, i.e. Empfänger.
Therefore I believe Ledger should always support and recognize the English name of special metadata tags.
| @@ -0,0 +1,2393 @@ | |||
| # German translations for Ledger package. | |||
There was a problem hiding this comment.
Several words like commodity have not (yet) been translated. This was already quite a bit of work as it is and my brain went 👻 while thinking in English when working on this PR and switching to translation mode when expanding on this file.
|
Ich denke wirklich nicht, dass ich qualifiziert bin, um die Übersetzungen speziell zu überprüfen, obwohl ich die Code-Änderungen gutheiße. Vielleicht könnte ein anderer Muttersprachler einschreiten und seine Zustimmung geben, wenn es fertig ist? |
|
Ich wusste gar nicht, daß Du so gut Deutsch sprichst, John! Heißt das, daß ich die PR Beschreibungen zukünftig komplett in Deutsch schreiben kann? 😅 |
|
Ach, es gab eine Zeit, in der ich das genossen hätte. Während meiner Highschool- und Collegejahre habe ich mit großer Intensität Deutsch gelernt und wollte tatsächlich nach Deutschland ziehen, um dort als Programmierer zu arbeiten. Doch dann vergingen die Jahre und es gab zu wenig Gelegenheiten, die Sprache hier in den Staaten anzuwenden. Und realistisch betrachtet ist es viel effizienter, wenn Deutsche mit mir auf Englisch kommunizieren, als wenn ich meine brüchigen Sprachkenntnisse an ihnen ausprobiere. Und so habe ich am Ende den Großteil meiner Fähigkeiten verloren. Glücklicherweise ist ChatGPT ein großartiger Assistent, der mir hilft, die Lücken zu füllen, wo das Vergessen mich eingeholt hat, und zumindest kann ich das Ergebnis Korrektur lesen und sicherstellen, dass ich nicht wie ein verrückter Mensch klinge. And so yes, much better to continue in English, to avoid the inefficiency of translation getting in the way of a timely response. :) |
|
I came across an article "[o]n writing better error messages" recently and feel somewhat inspired to re-work the existing messages Ledger prints. My thinking is around coming up with a "scheme" for message-categories, i.e. how can error messages be differentiated linguistically from info messages. How would you feel about a PR that may or may not rewrite the majority of Ledger's messages, @jwiegley? ℹ️ The article's essence is:
|
|
Can you show me a few examples? That would better help me determine if the heavy lift is worth your time... |
|
That is very considerate, @jwiegley, thank you. I believe it is worth the time to do soon, i.e. before folks volunteer to translate into other languages, as such a potentially large scale change will effectively require the re-translation. Here are some quick examples:
And maybe a first good take is consolidating use of 'Cannot' vs' Could not' and proper quoting of arguments within messages. I just had an interesting idea: We could use gettext to get a feel for rewording by simply providing po/en.po with different messages 😆 |
|
The latter two are definitely an improvement, but I find the top two to be more confusing. They don't directly inform the user about the mistake they made. By rephrasing it in terms of what would have worked, it can make the actual problem harder to spot... |
|
That's helpful feedback, John, how about we direct our attention to getting #2242 merged first, then can have a look at potential changes to the English messages for wording and consistency, and then come back to this PR? Is this acceptable for you? |
|
Oh yes, that sounds great, Alexis! Good work you're doing here, and I think it will be helpful to many once we hammer it out. |
This PR adds a very first (read: bad) translation of Ledger's messages to 🇩🇪. As a native speaker I should be able to do a better job (and will). Yet my focus for this PR was to get an impression on all (~500 😮💨) the Ledger messages and the infrastructure to support international languages in Ledger.
I will look for inspiration from translationproject, oftentime when developing (and thinking) in English it is hard for me to switch back and forth to German when trying to come up with good translation.
Please see below for inline comments and context about the changes.
One thing to emphasise are the changes related to handling special metadata tags, e.g.
PayeeundUUID. Ledger currently allows these to be translated (and it does make sense) yet for compatibility I believe ledger should always recognize and support the English version.This is a companion PR that stacks on top of #2242.
Tested using nix 🥳:tada:
TODO