Fix for #2031 #2336
Open
Fix for #2031 #2336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm not actually sure the test command's output is correct.
This seems to work just fine. Therefore I think the problem is in the balance assignment logic.
This adds a new flag to the post class(?) to state whether the posting is for a timelog entry. Then the class' must_balance method is updated to take that flag in to account. Finally, the timelog file is updated to create postings with that flag set, allowing them to avoid the balance requirement.
|
@tbm can you help me out here? I think that I understand why the two tests failed, but I'm not certain the behavior that It'd also be nice if you could point me to documentation on the postings in |
|
Unfortunately don't know anything about this. @jwiegley can you comment on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch includes a solution for #2031, but also causes two tests to fail, that don't fail on the master branch:
What I found happening is that time log entries were treated as virtual postings, but I am not sure if that is the intended way to treat them, or just a workaround to ensure they can get past the usual requirement that a posting should balance -- my solution assumes the latter.
My solution therefore adds a new flag to state whether a posting is for a time log entry, and thereby returns false from the post class'
must_balancemethod, when that flag is set on the posting.The two tests that fail include a virtual(?) posting that I have never seen before (and cannot find mentioned in the docs), and a time log entry that is asserted to have been posted to a virtual account.