feat: Add optional skipAspectRatioCheck #161
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In my project, I need to make a manual crop for video.
For example - I make a horizontal crop(16/9) for a video with a vertical aspect ratio(9/16) with scaling it.
Actual result:
![image](https://private-user-images.githubusercontent.com/135326716/272193565-47262f30-4e21-4ae3-9e40-f3853bc99bc1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwNTY2NzgsIm5iZiI6MTcxODA1NjM3OCwicGF0aCI6Ii8xMzUzMjY3MTYvMjcyMTkzNTY1LTQ3MjYyZjMwLTRlMjEtNGFlMy05ZTQwLWYzODUzYmM5OWJjMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxMFQyMTUyNThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT02YWU3NjE4NTQzNDZmZjY3ODE1NjA2Zjc1ZTZkZGM3ZGZlYzQxNThhNzEzZmJmYjMyYmIzYzYxYzEyYWJhNjM3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.I515e3FQR3Z0nqcKBNEyow5fOJziPdQEqkyIILNj0LY)
This happens because the subtitles octopus checks the original video aspect ratio and gets the width according to this value.
self.getVideoPosition = function () { var videoRatio = self.video.videoWidth / self.video.videoHeight; var width = self.video.offsetWidth, height = self.video.offsetHeight; var elementRatio = width / height; var realWidth = width, realHeight = height; if (elementRatio > videoRatio) realWidth = Math.floor(height * videoRatio); else realHeight = Math.floor(width / videoRatio); .... }
Expected result:
![image](https://private-user-images.githubusercontent.com/135326716/272194452-b6ddfabb-454c-41bf-95fd-f55864e206c3.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MTgwNTY2NzgsIm5iZiI6MTcxODA1NjM3OCwicGF0aCI6Ii8xMzUzMjY3MTYvMjcyMTk0NDUyLWI2ZGRmYWJiLTQ1NGMtNDFiZi05NWZkLWY1NTg2NGUyMDZjMy5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjQwNjEwJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI0MDYxMFQyMTUyNThaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0zMTg4YWI0YTc2NzQ0YWIxMDU0ZTY1MGFlNTljZDNjODYyMTRmMWY5NmJjYzllZmQ5YzUxZTViOTM3NzcxNjc3JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.f6QCxBmTkTKSPNLEflIL361Hu4PudVZcF9T2yIXKhZM)
I understand that my case is non-standard, so I allowed to hide standard behavior by optional prop