Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Scaffold] TableFromExpression and QueryFromExpression support #4506

Closed
wants to merge 1,016 commits into from
Closed

[Scaffold] TableFromExpression and QueryFromExpression support #4506

wants to merge 1,016 commits into from

Conversation

MaceWindu
Copy link
Contributor

@MaceWindu MaceWindu commented May 13, 2024 •
edited

  • updated CLI scaffold to use TableFromExpression and QueryFromExpression helper for generated table functions
  • updated T4 scaffold to use TableFromExpression helper for generated table functions
  • removed CLI naming options table-function-methodinfo-field-name
  • [Firebird] updated boolean type scaffold to use DataType.Boolean
  • broke .cctor call loop between provider detectors and DataConnection
  • [T4][Access] removed T4 function LoadAccessMetadataByProvider, use LoadAccessMetadata instead
  • [T4][Informix] removed T4 function LoadInformixMetadata with string providerName overload. Use same function without additional parameter
  • [T4][Informix] added InformixProvider provider optional parameter to LoadInformixMetadata
  • [T4][SqlServer] remove provider optional parameter from LoadSqlServerMetadata API
  • [T4][SAP HANA] removed string providerName optional parameter in LoadSapHanaMetadata API

As a bonus, .NET FX tests work again in VS

sdanyliv and others added 30 commits March 3, 2024 16:39
@sdanyliv
Fixed infinite loop for NETFX.
8feb9a3
@sdanyliv
Another optimization case.
8ddf861
@sdanyliv
InLst test fixes.
5b607c0
@sdanyliv
Improved query cache sync.
bc2897c
@sdanyliv
Disabled test for SQLite.
f74429b
@sdanyliv
Fixed caching issues.
93eee24
@sdanyliv
SqlCe provider fixes.
54bb6d9
@sdanyliv
Fix Release build.
8cc6ca5
@sdanyliv
DB2 fixes.
01191cc
@sdanyliv
Fixed cache issue.
1cc5ff5
@sdanyliv
Preserver search condition order.
11b0a4c
@sdanyliv
Simplified Expressions Mapping handling.
2c54c6c
@sdanyliv
SqlTableLikeSource refactoring.
65cc6da
@sdanyliv
Fixed SAPHANA provider.
a2c9fa1
@sdanyliv
Disable remote test.
36ab047
@MaceWindu
benchmarks update (use .net 6 results for comparison)
ea96582
@sdanyliv
Disable remote call for test which prodcuces different SQL.
54b913d
@sdanyliv
Fixed MakeDateTime2 test.
f906cb8
@sdanyliv
Fixed MySql tests.
80672bd
@sdanyliv
Disabled remote tests.
0540b56
@sdanyliv
Fixed custom expression generation.
3683f99
@sdanyliv
Custom expressions fixes.
5e82431
@sdanyliv
Added possibility to inline parameters precisely.
91032f2
@sdanyliv
Added missing NOT inversion.
7a891a1
@sdanyliv
Added SqlCE Right function translation.
c39db2e
@sdanyliv
Fixed test conflicts.
8632732
@sdanyliv
Corrected SqlServer update with hints.
35a695a
@sdanyliv
Fixed test's assertion.
2ba06d3
@sdanyliv
Fixed comparison generation regression.
da7df24
@sdanyliv
Fixed SqlCe update table name generation.
f2aaf4a
@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

MaceWindu and others added 3 commits May 15, 2024 13:50
@MaceWindu
final touch
2111aef
@jogibear9988 @sdanyliv @MaceWindu
test for issue #4390 (#4391)
9eb8a9a 
* test for issue #4390

* Corrected tests.

---------

Co-authored-by: Svyatoslav Danyliv <sdanyliv@gmail.com>
Co-authored-by: MaceWindu <MaceWindu@users.noreply.github.com>
@MaceWindu
- TableFromExpression and QueryFromExpression support
e5f827d 
- scaffold fixes
sdanyliv
sdanyliv previously approved these changes May 15, 2024
View reviewed changes
viceroypenguin
viceroypenguin previously approved these changes May 15, 2024
View reviewed changes
@MaceWindu
Copy link
Contributor Author

/azp run test-all

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@linq2dbot linq2dbot mentioned this pull request May 15, 2024
Closed
@linq2dbot
Copy link

Test baselines changed by this PR. Don't forget to merge/close baselines PR after this pr merged/closed.

Base automatically changed from refactor/parsing to version_6 May 29, 2024 13:26
@MaceWindu MaceWindu dismissed stale reviews from viceroypenguin and sdanyliv May 29, 2024 13:26

The base branch was changed.

@MaceWindu MaceWindu mentioned this pull request May 29, 2024
Merged
@MaceWindu
Copy link
Contributor Author

Rebased to #4515 after parser merge

@MaceWindu MaceWindu closed this May 29, 2024
@MaceWindu MaceWindu deleted the testing/scaffold branch May 29, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sdanyliv sdanyliv sdanyliv left review comments

@viceroypenguin viceroypenguin viceroypenguin left review comments

@igor-tkachev igor-tkachev Awaiting requested review from igor-tkachev

@jods4 jods4 Awaiting requested review from jods4

@Shane32 Shane32 Awaiting requested review from Shane32

Assignees
No one assigned
Labels
None yet
Milestone
6.0.0-preview.1
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MaceWindu @linq2dbot @sdanyliv @viceroypenguin @jogibear9988