generated addPrimaryKey changes should not include column direction (DAT-17467) #5922

StevenMassaro · 2024-05-15T17:51:45Z

Impact

Bug fix (non-breaking change which fixes expected existing functionality)
Enhancement/New feature (adds functionality without impacting existing logic)
Breaking change (fix or feature that would cause existing functionality to change)

Previously, diff-changelog would errorenously create addPrimaryKey changes which included the column direction:

        <addPrimaryKey columnNames="ID DESC" constraintName="PK_MyTest" tableName="MyTest"/>

This PR changes the generated change to:

        <addPrimaryKey columnNames="ID" constraintName="PK_MyTest" tableName="MyTest"/>

generated addPrimaryKey changes should not include column direction

eddc15a

StevenMassaro temporarily deployed to internal May 15, 2024 17:51 — with GitHub Actions Inactive

StevenMassaro added the TypeBug label May 15, 2024

StevenMassaro added 2 commits May 15, 2024 13:19

close output stream after running snapshot

f5ed53e

update test name and fix delete

4b1d30a

StevenMassaro temporarily deployed to internal May 15, 2024 18:19 — with GitHub Actions Inactive

StevenMassaro marked this pull request as ready for review May 15, 2024 19:10

StevenMassaro requested a review from filipelautert as a code owner May 15, 2024 19:10

filipelautert approved these changes May 15, 2024

View reviewed changes

Merge branch 'master' into DAT-17467

aaa71fb

suryaaki2 temporarily deployed to internal May 23, 2024 13:50 — with GitHub Actions Inactive

suryaaki2 merged commit 533ea05 into master May 23, 2024
34 of 35 checks passed

suryaaki2 deleted the DAT-17467 branch May 23, 2024 17:50