-
-
Notifications
You must be signed in to change notification settings - Fork 7.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛fix: wrong judgement on client fetch #2519
Conversation
@cy948 is attempting to deploy a commit to the LobeHub Team on Vercel. A member of the Team first needs to authorize it. |
👍 @cy948 Thank you for raising your pull request and contributing to our Community |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2519 +/- ##
==========================================
- Coverage 93.43% 93.42% -0.01%
==========================================
Files 325 325
Lines 19686 19689 +3
Branches 2331 2330 -1
==========================================
+ Hits 18393 18395 +2
- Misses 1293 1294 +1 ☔ View full report in Codecov by Sentry. |
需要补充一条单测 |
Need to add a single test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
我觉得仍然应该是默认服务端请求,直到用户填写了 proxy 之后,才会显示允许 client 请求。 |
I think it should still be the default server request. The client request will not be allowed until the user fills in the proxy. |
❤️ Great PR @cy948 ❤️ The growth of project is inseparable from user feedback and contribution, thanks for your contribution! If you are interesting with the lobehub developer community, please join our discord and then dm @arvinxx or @canisminor1990. They will invite you to our private developer channel. We are talking about the lobe-chat development or sharing ai newsletter around the world. |
🎉 This PR is included in version 0.160.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
💻 变更类型 | Change Type
🔀 变更说明 | Description of Change
src/store/user/slices/settings/selectors/modelConfig.ts
: 不再根据用户填写的 endpoint 自动开启客户端请求;== 05/16/2024 更新 ==
src/store/user/slices/settings/selectors/modelConfig.test.ts
: 增加两条测试:== 05/17/2024 更新 ==
src/app/(main)/settings/llm/Azure/index.tsx
:展示 Azure Provider 的”客户端请求“功能; fix [Bug] Azure OpenAI does not provide server-side option #2487📝 补充信息 | Additional Information