Proof of bug: missing mercatorMatrix3d #3796
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When writing a CustomLayerInterface in a 3D context, the developer has need of a 3D equivalent to the mercatorMatrix, but none is provided by the interface. This showcases the issue caused by the lack of one, and has a basic example of how to fix.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3796 +/- ##
==========================================
+ Coverage 86.64% 86.73% +0.08%
==========================================
Files 240 240
Lines 32273 32276 +3
Branches 1977 1974 -3
==========================================
+ Hits 27963 27993 +30
+ Misses 3376 3347 -29
- Partials 934 936 +2 ☔ View full report in Codecov by Sentry. |
|
@olsen232 can we close this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When writing a CustomLayerInterface in a 3D context, the developer has need of a 3D equivalent to the mercatorMatrix, but none is provided by the interface. This showcases the issue caused by the lack of one, and has a basic example of how to fix.
Currently only intended to showcase the issue - will rewrite once I've opened an issue to discuss the proper fix.
Issue filed as #3797