Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: selection dot improvement #106

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: selection dot improvement #106

wants to merge 1 commit into from
+53 −7

Conversation

Yusang-park
Copy link

Hello! I'm glad to contribute to this library.

I fixed a bug related to the selection dot and added the selectedDate field.

Features

  • Fixed the issue where onPointSelected was being called infinitely when removing focus from the selection dot.
  • Added the selectedDate field to set the default coordinates of the selection dot. This is useful for scenarios like sharing selection across multiple charts.

@Yusang-park Yusang-park force-pushed the feat/yu-selection-dot-improvement branch 2 times, most recently from 3ac3355 to 8c7585c Compare May 19, 2024 05:11
@Yusang-park Yusang-park force-pushed the feat/yu-selection-dot-improvement branch from 8c7585c to 53a05eb Compare May 19, 2024 05:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Yusang-park