Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize CI #9857

Merged
merged 7 commits into from
May 21, 2024
Merged

Optimize CI #9857

merged 7 commits into from
May 21, 2024

Conversation

djhi
Copy link
Contributor

@djhi djhi commented May 17, 2024

Parallelize the CI steps to avoid rebuilding the project several times. This should reduce the total number of CI minutes consumed for each build, at the price of a slightly longer build (because we need to reinstall yarn dependencies).

Build time

Before After
4m 35s 5m 38s

Total build time

Before After
22m 08s 16m 17s

@fzaninotto
Copy link
Member

To be rebased now that #9829 is merged. Also, could you move the simple example build out of the typecheck step to reduce the build time?

@@ -71,6 +94,7 @@ jobs:

e-commerce:
runs-on: ubuntu-latest
needs: [typecheck]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now depends on the typecheck job. The build step also run a typecheck on the e-commerce demo

@@ -100,6 +128,7 @@ jobs:

crm:
runs-on: ubuntu-latest
needs: [typecheck]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now depends on the typecheck job. The build step also run a typecheck on the crm demo

.github/workflows/test.yml Outdated Show resolved Hide resolved
@fzaninotto fzaninotto merged commit 67dea51 into next May 21, 2024
14 checks passed
@fzaninotto fzaninotto deleted the optimize-ci branch May 21, 2024 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFR Ready For Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants