Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default bcc #7681

Closed
wants to merge 2 commits into from
Closed

add default bcc #7681

wants to merge 2 commits into from

Conversation

regevbr
Copy link
Contributor

@regevbr regevbr commented Jul 10, 2019

Q A
Bug fix? No
New feature? Yes
Automated tests included? No
Related user documentation PR URL mautic/documentation#314
Related developer documentation PR URL N/A
Issues addressed (#s or URLs) N/A
BC breaks? No
Deprecations? No

Description:

Add the ability to set a default BCC, so any mail that was not set with one, will get the default one (if set).
1 use case is to save all outgoing emails in a different email account for debugging and history preservation - with this feature it is much easier to achieve without changing 100's of email configurations

Steps to test this PR:

  1. Load up this PR
  2. Set a default BCC address in the email configuration section
  3. Send out a test email and make sure it was sent to the bcc address as well. ( you will need to configure the email settings to something that will actually send out emails)
  4. Create an email template, and set a different bcc email to it
  5. Get the email to be sent out (in a flow) and make sure that it was bcc'd to the email specif address and not the default one

@regevbr
Copy link
Contributor Author

regevbr commented Jul 10, 2019

@escopecz @kuzmany can you please review and feedback?

full disclosure: I didn't write php for 7 years or so - actually had to google "php check if array is empty" :-)

Awesome product by the way!

@escopecz
Copy link
Sponsor Member

I don't see any issue with your code. Nice work! It just must be tested.

@escopecz escopecz added feature A new feature for inclusion in minor or major releases ready-to-test PR's that are ready to test labels Jul 11, 2019
@escopecz escopecz added this to the 2.16.0 milestone Jul 11, 2019
@regevbr
Copy link
Contributor Author

regevbr commented Jul 11, 2019

@escopecz thanks!
Anything else needed on my part?

@escopecz
Copy link
Sponsor Member

Just patience. There is not so many testers.

@npracht npracht added this to Ready to Test (first time) in Mautic 2 Aug 15, 2019
@npracht npracht removed this from the 2.16.0 milestone Jan 23, 2020
@npracht npracht added Triage M2/M3 and removed ready-to-test PR's that are ready to test labels Apr 6, 2020
@npracht
Copy link
Member

npracht commented Apr 6, 2020

Hi there!
It has been decided to not create any extra Mautic 2 minor versions (which means no more features in M2) knowing that Mautic 3 is coming very soon.

We now want to integrate your contribution in the Mautic 3 roadmap as 3.1.0 candidate.

How to do?

  1. Check if your feature or enhancement is still missing and relevant in Mautic 3
  2. If Yes: rebase your PR against the 3.x branch
  3. If No: please consider closing your PR if you are absolutely sure that the feature has made it into Mautic 3 already

Please report results by commenting on your PR to make us administration easier.


You can more information on how to do all of that on this blog post "Getting you PR ready for Mautic 3".

@RCheesley
Copy link
Sponsor Member

@regevbr could you take a look at the conflict?

@RCheesley RCheesley added has-conflicts Pull requests that cannot be merged until conflicts have been resolved pending-feedback PR's and issues that are awaiting feedback from the author labels Jul 21, 2020
@RCheesley
Copy link
Sponsor Member

@cla-bot check

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2020

We require contributors to sign our Contributor License Agreement, and we do not have a record of your signature on file. In order for us to review and merge your code, please head over to https://www.mautic.org/contributor-agreement and complete the form. There may be a short delay while the team add you as a contributor - please be patient :). Any problems contact @RCheesley. CLA has not been signed by @regevbr.

@cla-bot
Copy link

cla-bot bot commented Aug 25, 2020

The CLA Bot has been sent on a mission to check against the latest list and will be back shortly with its findings!

@RCheesley
Copy link
Sponsor Member

Hi @regevbr another PR here - we would need you to sign the contributors agreement, and let us know if you're able to fix the outstanding conflicts.

Please let us know, if we don't hear from you within 14 days we'll close the PR.

@npracht npracht changed the base branch from staging to features November 30, 2020 17:54
@stale
Copy link

stale bot commented Feb 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Issues which have not received an update within 90 days label Feb 28, 2021
@npracht
Copy link
Member

npracht commented Mar 5, 2021

This is too old. i'll close it and if someone want to carry it again, then we'll re-open it with huge pleasure.

@npracht npracht closed this Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature A new feature for inclusion in minor or major releases has-conflicts Pull requests that cannot be merged until conflicts have been resolved pending-feedback PR's and issues that are awaiting feedback from the author stale Issues which have not received an update within 90 days
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants