Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling HTTP Request failures #34

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jonasrla
Copy link

@jonasrla jonasrla commented Dec 2, 2021

Hello,

While using the API I missed seeing some messaging on the exception, so I add the same messaging format from HTTPError.
Also, as a suggestion, wouldn't be possible too just use requests response.ok to decide whether raising or not exception?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant