-
-
Notifications
You must be signed in to change notification settings - Fork 259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor simple react jsx to typescript #1066
Conversation
loading-spinner component is refactored to typescript
Refactor help page to typescript
Added React component Documentation
Refactor privacy page to use typescript
Refactor licensing page to typescript
Refactor develop page to typescript
Refactor contribute page to typescript
Refactor about page to typescript
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These files were not really the primary target for this ticket, since there isn't much to do in terms of typing, but why not? We might as well have the return type.
Thanks in any case !
There is also a merge conflict that needs to be resolved, because I waited too long for the review (sorry!) |
Co-authored-by: Monkey Do <MonkeyDo@users.noreply.github.com>
…site into static-pages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The requested changed have been made
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
And sorry for reviewing it so late!
I took the liberty to resolve the merge conflicts.
Problem
A lot of the codebase has been written in javascript lacking the type handlings in the code editor.
Solution
The codebase has been shifting towards typescript and thus to maintain consistency, existing components should be refactored to typescript.
Areas of Impact
src/client/components/loading-spinner.tsx
src/client/components/pages/faq.tsx
src/client/components/pages/help.tsx
src/client/components/pages/privacy.tsx
src/client/components/pages/licensing.tsx
src/client/components/pages/develop.tsx
src/client/components/pages/contribute.tsx
src/client/components/pages/about.tsx