Fix BB-760 : When elasticsearch configuration is missing, server crashes

[Tarunmeena0901]

Problem

BB-760

Solution

As the reason behind the crashing of BB server was the absence of elastic search configuration in our configuration template , I added some checks just before we are initializng the search server in app.js .
Those checks will ensure incase of missing configuration elastic search will still get some hardcoded configuration which will prevent it from crashing on initializing

and also incase of missing configuration error will be logged in console and a warning banner will be displayed on homepage

Areas of Impact

• ./src/server/app.js
• ./src/api/app.js

[MonkeyDo]

Sorry for the long delay!
I have some suggestions to simplify the code a bit and deduplicate some code:

[Tarunmeena0901]

There were some unexpected es lint error not releated to the changes in this PR , but I fixed them too I hope it does no make things confusing for you

[MonkeyDo]

There were some unexpected es lint error not releated to the changes in this PR , but I fixed them too I hope it does no make things confusing for you

Thanks for the changes, reviewing now.
For posterity, it's not ideal as it touches a bunch of files that are unrelated.
That being said, the changes in question are so minor that it really isn't an issue to review.

In case it's useful in the future, you can run eslint for specific files instead by passing a file path to the commend:
npx eslint path/to/my/file

[MonkeyDo]

Perfect, thanks!

[MonkeyDo]

Great solution! One thing I would like to ask: the type you mentioned here {type ClientOptions} from '@elastic/elasticsearch'; doesn't have the properties that options should have like "auth" and "host"

options = {
	auth: { password: 'changeme', username: 'elastic' },
	node: 'http://localhost:9200',
	requestTimeout: 60000,
	host: 'localhost:9200'
};

Thanks for pointing this out!
I took a closer look and indeed the configuration was incorrect> I took the liberty to piggyback on the PR and fix it, since there were a few places to fix it but not very obvious.
While adding the typescript type to the ES client, it also raised a separate issue which I also fixed.

Hope you don't mind my meddling!