allow serialize_to_str to work with non ascii when dumping via json.d…

[jtoy]

allow serialize_to_str to work with non ascii when dumping via json.dumps

Why are these changes needed?

developers will use serialize_to_str with non ascii characters, this allows them to do that.

Related issue number

Closes #2511

Checks

• I've included any doc changes needed for https://microsoft.github.io/autogen/. See https://microsoft.github.io/autogen/docs/Contribute#documentation to build and test documentation locally.
• I've added tests (if relevant) corresponding to the changes introduced in this PR.
• I've made sure all auto checks have passed.

[marklysze]

Hi @jtoy, I have used json.dumps in the GroupChatManager to serialise messages for use in resuming chats later on:

Code here

Do you think it would be worth adding the ensure_ascii=False parameter to this line of code too?

UPDATE: see next comment...

[marklysze]

An update on my question...

I've tested my GroupChat code with and without the ensure_ascii=False and although the serialisation has the coded characters (e.g. \\u4e2d instead of 中) when it is False, it will still restore the messages correctly with 中 irrespective of whether ensure_ascii is True or False. I have also checked saving it to disk and loading from desk and it works fine.

So, for the purposes of serialising messages for saving GroupChat messages and resuming from it, it's not necessary to change the code I suggested.

[jtoy]

@marklysze Are you sure it went through similar code paths? In my PR, I added a unit test that shows if ensure_ascii is not used, it will change the formatting.

[jtoy]

The PR I wrote is still valid, can someone review the PRs please.

[marklysze]

@marklysze Are you sure it went through similar code paths? In my PR, I added a unit test that shows if ensure_ascii is not used, it will change the formatting.

Hi @jtoy, I used it to save to a file, then load from the file, and back into messages and without ensure_ascii=False the resulting messages were the same.

Your scenario may be different to mine so I think, as you are doing, you should continue with the PR, I just didn't see it affect the code section I referenced.

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.54%. Comparing base (11d9336) to head (d7f0811).
Report is 24 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2714      +/-   ##
==========================================
+ Coverage   33.60%   40.54%   +6.94%     
==========================================
  Files          87       87              
  Lines        9336     9386      +50     
  Branches     1987     2154     +167     
==========================================
+ Hits         3137     3806     +669     
+ Misses       5933     5229     -704     
- Partials      266      351      +85     

Flag	Coverage Δ
unittests	40.49% <100.00%> (+6.89%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.