Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove trailing comma from DID JSON document #1727

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Remove trailing comma from DID JSON document #1727

wants to merge 1 commit into from

Conversation

takuro-sato
Copy link
Contributor

JSON doesn't allow trailing commas (https://www.json.org/json-en.html), so the current implementation can cause parse errors.
The fixed code follows didx509cpp's implementation.

@takuro-sato takuro-sato requested a review from a team as a code owner April 12, 2023 08:53
@takuro-sato
Remove trailing comma from DID JSON document
6f0f092 
Signed-off-by: Takuro Sato <takurosato@microsoft.com>
KenGordon
KenGordon approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@KenGordon KenGordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Note for everyone else. This string is ignored so we don't really need this fix right now. If there was an issue it would be in checking that fragments are good.

@takuro-sato takuro-sato mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KenGordon KenGordon KenGordon approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@takuro-sato @KenGordon