Vendor containerd 2.0 #1958
Open
Vendor containerd 2.0 #1958
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Containerd module has changed version to 2.0, This commit changes all of the contained package imports within hcsshim to use the new imports paths for containerd v2 module. Containerd has also made some changes to the client APIs. There is now a new `client` package in containerd that hosts all of the client related code. Our tests have been updated to use this new package. Signed-off-by: Amit Barve <ambarve@microsoft.com>
ambarve
force-pushed
the
user/ambarve/vndr_ctrd_2
branch
from
7ebe6aa
to
4ef26d7
Compare
|
A bit concerned about this change... Shouldn't we wait till 2.0 is fully released before considering vendoring it in? Are there issues with us updating to 2.x around compatibility with our downstream consumers if they still use 1.x themselves? |
Hi @kevpar , Derek mentioned yesterday that this change would be needed before 2.0 tag is cut (in about a month from now). Beta tag of containerd/2.0 is scheduled to go out before Kubecon on Monday. Also, what do you mean by downstream consumers? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Containerd module has changed version to 2.0, This commit changes all of the contained package imports within hcsshim to use the new imports paths for containerd v2 module.
Containerd has also made some changes to the client APIs. There is now a new
clientpackage in containerd that hosts all of the client related code. Our tests have been updated to use this new package.