Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New version: Apache.Groovy.2 version 2.5.23 #154124

Conversation

SpecterShell
Copy link
Contributor

@SpecterShell SpecterShell commented May 18, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 18, 2024
@stephengillie
Copy link
Collaborator

Automatic Validation ended with:

Executable C:\Windows\SysWOW64\cmd.exe returned exit code: 1

(Automated response - build 881.)

@stephengillie
Copy link
Collaborator

Hi @SpecterShell,

This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.

(Automated response - build 881.)

@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Author-Feedback This needs a response from the author. label May 20, 2024
@SpecterShell
Copy link
Contributor Author

SpecterShell commented May 21, 2024

Hi @SpecterShell,

This manifest adds Apps and Features entries that aren't present in previous PR versions. These entries should be added to the previous versions, or removed from this version.

(Automated response - build 881.)

It should be fine to add such Apps and Features entries in this PR. 🤔

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 21, 2024
@stephengillie
Copy link
Collaborator

Yes - it's ProductCode and UpgradeCode. Sorry to miss this one.

@microsoft-github-policy-service microsoft-github-policy-service bot merged commit 6d7ee30 into microsoft:master May 21, 2024
8 checks passed
@microsoft-github-policy-service microsoft-github-policy-service bot added the Moderator-Approved One of the Moderators has reviewed and approved this PR label May 21, 2024
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@SpecterShell SpecterShell deleted the Apache.Groovy.2-2.5.23-3B72AD47 branch May 21, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants