Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New package: Mattodev.Lifetime version 0.5.1 #154146

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Matto58
Copy link

@Matto58 Matto58 commented May 18, 2024

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.6 schema?

Note: <path> is the name of the directory containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Matto58
Copy link
Author

Matto58 commented May 18, 2024

@microsoft-github-policy-service agree

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 18, 2024
@stephengillie
Copy link
Collaborator

stephengillie commented May 20, 2024

Automatic Validation ended with:

Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Packages\Mattodev.Lifetime__DefaultSource\mtdeploy-1.0.0-win-x64.exe returned exit code: -2147450749
Executable C:\Users\validator\AppData\Local\Microsoft\WinGet\Links\mtdeploy-1.0.0-win-x64.exe returned exit code: -2147450749

(Automated response - build 881.)

Edit: Hi @Matto58,

-2147450749 appears to indicate a missing dependency on Microsoft.DotNet.DesktopRuntime.8.

Copy link
Collaborator

@stephengillie stephengillie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

InstallerType: portable
InstallerSwitches:
Custom: https://github.com/Matto58/lifetime/releases/download/v0.5.1-beta/lifetime-0.5.1-win-x64.zip Mattodev Lifetime
Installers:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Installers:
Dependencies:
PackageDependencies:
- PackageIdentifier: Microsoft.DotNet.DesktopRuntime.8
Installers:

@stephengillie
Copy link
Collaborator

stephengillie commented May 20, 2024

With the dependency added, the application errors. Is this expected?
image

Edit: Verify:
image

@Matto58
Copy link
Author

Matto58 commented May 22, 2024

With the dependency added, the application errors. Is this expected? image

Edit: Verify: image

prob not, some bug in my code, i tried to write an installer that installs the program but apparently winget does that for me, i thought i had to do that myself, sorry for these dumb mistakes, it's my first time submitting a package here

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels May 22, 2024
@Matto58
Copy link
Author

Matto58 commented May 22, 2024

is it okay if i make another commit with just the program (and the dependency edit you suggested)?

edit: oh wait you did that already in the suggestion tysm, but im not sure if i can just update it since iirc only 1 commit can be in 1 pr

@hackean-msft
Copy link
Contributor

@wingetbot installationmetadata exe remove mtdeploy-1.0.0-win-x64.exe

@wingetbot
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Executable-Error labels May 28, 2024
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Executable-Error labels May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Changes-Requested Changes Requested New-Package Validation-Executable-Error
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants