Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove date in the end of ubuntu base image version #33073

Merged
merged 2 commits into from
Jun 5, 2024

Conversation

weiZhenkun
Copy link
Contributor

@weiZhenkun weiZhenkun commented May 15, 2024

CVE issues #31997
This PR will fix 32 LOW and 42 MEDIUM CVEs

ubuntu:focal-20220426 (ubuntu 20.04)
Total: 99 (UNKNOWN: 0, LOW: 55, MEDIUM: 44, HIGH: 0, CRITICAL: 0)
ubuntu:focal (ubuntu 20.04)
Total: 25 (UNKNOWN: 0, LOW: 23, MEDIUM: 2, HIGH: 0, CRITICAL: 0)
image
image

Signed-off-by: weizhenkun <zhenkun.wei@qq.com>
@sre-ci-robot
Copy link
Contributor

Welcome @weiZhenkun! It looks like this is your first PR to milvus-io/milvus 🎉

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 15, 2024
@mergify mergify bot added the dco-passed DCO check passed. label May 15, 2024
Copy link
Contributor

mergify bot commented May 15, 2024

@weiZhenkun

Invalid PR Title Format Detected

Your PR submission does not adhere to our required standards. To ensure clarity and consistency, please meet the following criteria:

  1. Title Format: The PR title must begin with one of these prefixes:
  • feat: for introducing a new feature.
  • fix: for bug fixes.
  • enhance: for improvements to existing functionality.
  • test: for add tests to existing functionality.
  • doc: for modifying documentation.
  • auto: for the pull request from bot.
  1. Description Requirement: The PR must include a non-empty description, detailing the changes and their impact.

Required Title Structure:

[Type]: [Description of the PR]

Where Type is one of feat, fix, enhance, test or doc.

Example:

enhance: improve search performance significantly 

Please review and update your PR to comply with these guidelines.

@weiZhenkun weiZhenkun changed the title remove date in the end of ubuntu base image version fix : remove date in the end of ubuntu base image version May 15, 2024
@weiZhenkun weiZhenkun changed the title fix : remove date in the end of ubuntu base image version fix: remove date in the end of ubuntu base image version May 15, 2024
@mergify mergify bot added kind/bug Issues or changes related a bug and removed do-not-merge/invalid-pr-format labels May 15, 2024
@weiZhenkun
Copy link
Contributor Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 15, 2024

@weiZhenkun E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@mergify mergify bot added the ci-passed label May 15, 2024
@weiZhenkun
Copy link
Contributor Author

@LoveEachDay could you review this PR?

@weiZhenkun
Copy link
Contributor Author

@xiaofan-luan could you review this PR?

@LoveEachDay
Copy link
Contributor

@weiZhenkun It's recommended to use a specific tag instead only focal, like focal-2024010.

Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.20%. Comparing base (dd9919a) to head (9df6d8e).
Report is 157 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #33073      +/-   ##
==========================================
+ Coverage   82.14%   82.20%   +0.05%     
==========================================
  Files        1006     1009       +3     
  Lines      128194   128856     +662     
==========================================
+ Hits       105306   105924     +618     
- Misses      18919    18944      +25     
- Partials     3969     3988      +19     

see 116 files with indirect coverage changes

@LoveEachDay
Copy link
Contributor

https://github.com/zilliztech/attu/blob/main/Dockerfile#L22 https://github.com/milvus-io/bitnami-docker-etcd/blob/3.5.0-new/3.5/debian-11/Dockerfile#L1 what about here?

We don't release attu and etcd image frequently, while milvus image are building after every pr has been merged. So keep the runtime base image stable is critical.

Signed-off-by: weizhenkun <zhenkun.wei@qq.com>
@mergify mergify bot removed the ci-passed label May 22, 2024
@weiZhenkun
Copy link
Contributor Author

/run-cpu-e2e

@weiZhenkun
Copy link
Contributor Author

weiZhenkun commented May 22, 2024

@LoveEachDay Change to latest version focal-20240427 now, please review, thanks.

@mergify mergify bot added the ci-passed label May 22, 2024
Copy link
Contributor

@LoveEachDay LoveEachDay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@weiZhenkun
Copy link
Contributor Author

/assign @yanliang567

@czs007
Copy link
Contributor

czs007 commented Jun 5, 2024

/approve

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, LoveEachDay, weiZhenkun

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 516f39b into milvus-io:master Jun 5, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants