feat: stream reader/writer to support nulls #33080
Conversation
mergify
bot
added
dco-passed
|
@tedxu Please associate the related issue to the body of your Pull Request. (eg. “issue: #”) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #33080 +/- ##
==========================================
+ Coverage 82.06% 82.10% +0.04%
==========================================
Files 1012 1012
Lines 128806 128902 +96
==========================================
+ Hits 105702 105840 +138
+ Misses 19112 19080 -32
+ Partials 3992 3982 -10
|
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
Signed-off-by: Ted Xu <ted.xu@zilliz.com>
|
@tedxu E2e jenkins job failed, comment |
|
/run-cpu-e2e |
|
@tedxu E2e jenkins job failed, comment |
| Type: arrays[i].DataType(), | ||
| Name: strconv.Itoa(int(fid)), | ||
| Type: arrays[i].DataType(), | ||
| Nullable: true, // No nullable check here. |
There was a problem hiding this comment.
why no nullable check here? it seem ok to get nullable in collection schema.
There was a problem hiding this comment.
There are two reasons why there is no nullable check:
- In compact operations, it is safe to suppose the compacting segments are valid. The nullable checks have been done at the insert time.
- The schema evolution feature requires nullable for almost all columns, making the schema property “not-nullable” useless. I suppose “not-nullable” may useful only in compile-time, e.g., in literal fields for constant folding optimizations.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, tedxu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See: #31728