Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable GetVectorFromChunkCache and WarmupChunkCache test #33115

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zhengbuqian
Copy link
Collaborator

check to see if the mem leak from AWS::InitSDK has been fixed, if so we can re-enable the test

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: zhengbuqian
To complete the pull request process, please assign czs007 after the PR has been reviewed.
You can assign the PR to them by writing /assign @czs007 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@zhengbuqian Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

@zhengbuqian
Copy link
Collaborator Author

turns out ASAN has been permanently disabled in #30498, but these 2 tests are failing due to:

img_v3_02av_74af3c88-a45c-49bc-9c46-deed2a645acg

Though in my local tests with ASAN enabled, memory leak still exists

@zhengbuqian
Copy link
Collaborator Author

the memory leak found in my local env was caused by #33139.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dco-passed DCO check passed. do-not-merge/missing-related-issue kind/bug Issues or changes related a bug size/XS Denotes a PR that changes 0-9 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants