Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: channel manager's goroutine run order #33118

Merged
merged 2 commits into from
May 21, 2024
Merged

fix: channel manager's goroutine run order #33118

merged 2 commits into from
May 21, 2024

Conversation

XuanYang-cn
Copy link
Contributor

See also: #33117

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 17, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 17, 2024
@XuanYang-cn XuanYang-cn changed the title fix: channel manager's goroutinue run order fix: channel manager's goroutine run order May 17, 2024
@codecov Codecov
Copy link

codecov bot commented May 17, 2024 •
edited

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.18%. Comparing base (a7f6193) to head (6925897).
Report is 18 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #33118   +/-   ##
=======================================
  Coverage   82.18%   82.18%           
=======================================
  Files        1009     1009           
  Lines      128806   128823   +17     
=======================================
+ Hits       105860   105878   +18     
+ Misses      18953    18952    -1     
  Partials     3993     3993
Files Coverage Δ
internal/datanode/channel_manager.go 90.20% <100.00%> (-2.08%) ⬇️

... and 41 files with indirect coverage changes

@mergify mergify bot added the ci-passed label May 17, 2024
@XuanYang-cn XuanYang-cn mentioned this pull request May 20, 2024
Merged
@XuanYang-cn
fix: channel manager's goroutine run order
1606df9 
See also: milvus-io#33117

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels May 20, 2024
@mergify mergify bot removed the ci-passed label May 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn ut workflow job failed, comment rerun ut can trigger the job again.

@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024

@XuanYang-cn E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@XuanYang-cn
fix coding styles
6925897 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added size/M Denotes a PR that changes 30-99 lines. and removed size/L Denotes a PR that changes 100-499 lines. labels May 20, 2024
@mergify mergify bot added the ci-passed label May 20, 2024
sre-ci-robot pushed a commit that referenced this pull request May 21, 2024
@XuanYang-cn
fix: [2.4]channel manager's goroutine run order (#33121)
b2f7d7b 
See also: #33117
pr: #33118

---------

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
congqixia
congqixia approved these changes May 21, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 2d6f12d into milvus-io:master May 21, 2024
15 checks passed
@XuanYang-cn XuanYang-cn deleted the fix/cm-ut branch May 21, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@congqixia congqixia congqixia approved these changes

@cydrain cydrain Awaiting requested review from cydrain

@sunby sunby Awaiting requested review from sunby

Assignees

@congqixia congqixia

Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@XuanYang-cn @sre-ci-robot @congqixia