Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check array field data is nil before getting the type #33119

Merged
merged 2 commits into from
May 18, 2024

Conversation

sunby
Copy link
Contributor

@sunby sunby commented May 17, 2024

issue: #33074

Signed-off-by: sunby <sunbingyi1992@gmail.com>
@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 17, 2024
@mergify mergify bot added the dco-passed DCO check passed. label May 17, 2024
Copy link
Contributor

mergify bot commented May 17, 2024

@sunby Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

Copy link
Contributor

mergify bot commented May 17, 2024

@sunby Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Copy link
Contributor

mergify bot commented May 17, 2024

@sunby ut workflow job failed, comment rerun ut can trigger the job again.

Signed-off-by: sunby <sunbingyi1992@gmail.com>
Copy link

codecov bot commented May 17, 2024

Codecov Report

Attention: Patch coverage is 16.66667% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 83.10%. Comparing base (0abc0d0) to head (0a1cc67).
Report is 3 commits behind head on 2.3.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.3   #33119      +/-   ##
==========================================
- Coverage   83.10%   83.10%   -0.01%     
==========================================
  Files         850      850              
  Lines      106596   106641      +45     
==========================================
+ Hits        88586    88622      +36     
- Misses      14710    14714       +4     
- Partials     3300     3305       +5     
Files Coverage Δ
internal/proxy/validate_util.go 89.38% <16.66%> (-2.53%) ⬇️

... and 15 files with indirect coverage changes

@sunby
Copy link
Contributor Author

sunby commented May 17, 2024

/kind branch-feature

Copy link
Contributor

mergify bot commented May 17, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@sunby
Copy link
Contributor Author

sunby commented May 17, 2024

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 17, 2024

@sunby E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@congqixia congqixia added this to the 2.3.16 milestone May 17, 2024
@xiaofan-luan
Copy link
Contributor

/lgtm
/approve

@xiaofan-luan xiaofan-luan merged commit b073407 into milvus-io:2.3 May 18, 2024
19 of 22 checks passed
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sunby, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved dco-passed DCO check passed. kind/branch-feature kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants