Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Access All Tables of Given Database Only for SQL Completions (fix) #9223

Merged
merged 3 commits into from
May 17, 2024

Conversation

tmichaeldb
Copy link
Contributor

Description

Before, any database that wasn't mindsdb would have tables eligible to be usable tables for SQL completions. However, we want to restrict to the provided database only (and default to all tables for that database).

Type of change

  • 馃悰 Bug fix (non-breaking change which fixes an issue)

Additional Media:

  • I have attached a brief loom video or screenshots showcasing the new functionality or change.

Checklist:

  • My code follows the style guidelines(PEP 8) of MindsDB.
  • I have appropriately commented on my code, especially in complex areas.
  • Necessary documentation updates are either made or tracked in issues.
  • Relevant unit and integration tests are updated or added.

@tmichaeldb tmichaeldb requested a review from dusvyat May 17, 2024 03:13
@tmichaeldb tmichaeldb self-assigned this May 17, 2024
@tmichaeldb tmichaeldb added the enhancement New feature or request label May 17, 2024
@tmichaeldb tmichaeldb merged commit b8db3b3 into main May 17, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants