Add cluster and bucket replication metrics in metrics-v3 #19546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
3 times, most recently
from
51ebac7
to
5e2021d
Compare
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
3 times, most recently
from
9025e25
to
17bd3b8
Compare
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
3 times, most recently
from
954544a
to
84ba7ed
Compare
|
Are we still using query string based endpoints? description of PR may need changes. |
shtripat
reviewed
May 6, 2024
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
from
7dfd284
to
2d8c2e0
Compare
@shtripat updated the description with bucket-as-path-component based endpoint. PTAL. |
shtripat
approved these changes
May 8, 2024
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
from
284c078
to
07ffeaa
Compare
endpoint: /minio/metrics/v3/cluster/replication metrics: - average_active_workers - average_queued_bytes - average_queued_count - average_transfer_rate - current_active_workers - current_transfer_rate - last_minute_queued_bytes - last_minute_queued_count - max_active_workers - max_queued_bytes - max_queued_count - max_transfer_rate - recent_backlog_count endpoint: /minio/metrics/v3/api/bucket/replication metrics: - last_hour_failed_bytes - last_hour_failed_count - last_minute_failed_bytes - last_minute_failed_count - latency_ms - proxied_delete_tagging_requests_total - proxied_get_requests_failures - proxied_get_requests_total - proxied_get_tagging_requests_failures - proxied_get_tagging_requests_total - proxied_head_requests_failures - proxied_head_requests_total - proxied_put_tagging_requests_failures - proxied_put_tagging_requests_total - sent_bytes - sent_count - total_failed_bytes - total_failed_count - proxied_delete_tagging_requests_failures
anjalshireesh
force-pushed
the
metrics-v3-replication
branch
from
97f0f0c
to
8e2c724
Compare
poornas
approved these changes
May 16, 2024
poornas
approved these changes
May 17, 2024
harshavardhana
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Contribution License
All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.
Description
endpoint: /minio/metrics/v3/replication
metrics:
endpoint: /minio/metrics/v3/bucket/replication metrics:
Motivation and Context
https://github.com/miniohq/engineering/issues/1510
How to test this PR?
Should return the new replication related metrics
Types of changes
Checklist:
commit-idorPR #here)